eZecosystem / Mirror / GG @ GitHub

gggeek commented on issue gggeek/phpxmlrpc#22
Gaetano Giunta

Mmm, not sure what you got, but in docbook-xsl-1.78.1.tar.bz2, there is definitely html/cunk.xsl ...

02/22/2015 10:13 am   Gaetano @ GitHub   Mirror   Link  
Gaetano Giunta
02/21/2015 05:19 pm   Gaetano @ GitHub   Mirror   Link  
gggeek commented on issue gggeek/phpxmlrpc#22
Gaetano Giunta

About installing the docbook xsl via composer: this is actually possible. I am not sure if it would conflict with a version installed, say, via apt…

02/21/2015 04:26 pm   Gaetano @ GitHub   Mirror   Link  
gggeek commented on issue gggeek/phpxmlrpc#22
Gaetano Giunta

As for the missing .../tools/docbook-xsl/xhtml/chunk.xsl file: the conversion process relies on having a copy of the xsl files available from the d…

02/21/2015 04:04 pm   Gaetano @ GitHub   Mirror   Link  
Gaetano Giunta
  • Gaetano Giunta 040d77f
    Make sure convert.php works with php5.6.1 on linux
02/21/2015 03:48 pm   Gaetano @ GitHub   Mirror   Link  
gggeek commented on issue gggeek/phpxmlrpc#22
Gaetano Giunta

About setSecurityPreferences vs. setSecurityPrefs: I am sure I had put that there inside an already hackish 'if' because it would not work otherwis…

02/21/2015 03:47 pm   Gaetano @ GitHub   Mirror   Link  
gggeek commented on issue gggeek/phpxmlrpc#13
Gaetano Giunta

Classes have been refactored and namespaced (in branch php53). Left to do: move all code in the demo/ and debugger/ directories to use the new naming

02/21/2015 03:36 pm   Gaetano @ GitHub   Mirror   Link  
gggeek commented on issue gggeek/phpxmlrpc#17
Gaetano Giunta

Partially done (in branch php53). Remains to be done: globals still used in Server.php and Wrapper.php - move to static class variables should do

02/21/2015 03:34 pm   Gaetano @ GitHub   Mirror   Link  
gggeek commented on issue gggeek/phpxmlrpc#18
Gaetano Giunta

Adding a comment here, to remember: add PHPMD/PHPCS into the build process while refactoring it

02/21/2015 03:32 pm   Gaetano @ GitHub   Mirror   Link  
Gaetano Giunta
clean up code formatting
02/21/2015 03:31 pm   Gaetano @ GitHub   Mirror   Link  
gggeek commented on issue gggeek/phpxmlrpc#12
Gaetano Giunta

Code has been reformatted in php53 branch according (afaik) to PSR-2. Adding PHPMD/PHPCS to the build process will happen as part of build-process …

02/21/2015 03:31 pm   Gaetano @ GitHub   Mirror   Link  
gggeek commented on issue gggeek/phpxmlrpc#14
Gaetano Giunta

Implemented, in php53branch

02/21/2015 03:29 pm   Gaetano @ GitHub   Mirror   Link  
Gaetano Giunta
use phpunit installed via composer for the test suite
02/21/2015 03:29 pm   Gaetano @ GitHub   Mirror   Link  
Gaetano Giunta
02/21/2015 03:25 pm   Gaetano @ GitHub   Mirror   Link  
Gaetano Giunta
  • Gaetano Giunta d5fba76
    Fix newlines (to satisfy automated code quality scanners)
02/21/2015 03:23 pm   Gaetano @ GitHub   Mirror   Link  
Gaetano Giunta
  • Gaetano Giunta 5f01a1f
    Fix two bugs (missed porting to new class names / namespaces), thanks…
02/21/2015 02:56 pm   Gaetano @ GitHub   Mirror   Link  
Gaetano Giunta
  • Gaetano Giunta e070014
    Fix one testcase apparently broken by automatic formatting tools
02/21/2015 02:40 pm   Gaetano @ GitHub   Mirror   Link  
Gaetano Giunta
  • Gaetano Giunta 0a32caf
    Improve documentation for v4; fix one typo in a comment
02/21/2015 02:28 pm   Gaetano @ GitHub   Mirror   Link  
Gaetano Giunta
02/21/2015 01:39 pm   Gaetano @ GitHub   Mirror   Link  
gggeek commented on pull request ezsystems/ezpublish-kernel#829
Gaetano Giunta

Sorry if I'm completely off the track, but I'm not sure I remember this happening in legacy stack... is it really desirable to put it here?

02/01/2015 02:25 pm   Gaetano @ GitHub   Mirror   Link   @3
gggeek commented on pull request ezsystems/ezoracle#22
Gaetano Giunta

It is ready for review. I will try to carve out some time for extra testing of the cluster code during the weekend.

01/30/2015 06:57 am   Gaetano @ GitHub   Mirror   Link   @7
01/30/2015 02:39 am   Gaetano @ GitHub   Mirror   Link   @114
Gaetano Giunta
  • Gaetano Giunta c195bd0
    Move to new-style copyright notices everywhere
01/29/2015 10:58 am   Gaetano @ GitHub   Mirror   Link   @113
Gaetano Giunta
  • Gaetano Giunta 6295c39
    remove support for ezdb clustering
01/29/2015 10:32 am   Gaetano @ GitHub   Mirror   Link   @125
Gaetano Giunta
  • Gaetano Giunta ad7dab0
    Backport all ezdfs cluster changes from 5.0 -> 5.3
01/29/2015 10:13 am   Gaetano @ GitHub   Mirror   Link   @115
Gaetano Giunta

Had a short discussion about this on twitter: https://twitter.com/seldaek/status/560778548441407488 Seems like including the 3 binaries and wrappin…

01/29/2015 07:12 am   Gaetano @ GitHub   Mirror   Link   @8
Gaetano Giunta

Sorry to chime in so late, but I am not 100% sure this should trigger a 'delete' event notification. Is it really wanted?

01/29/2015 03:01 am   Gaetano @ GitHub   Mirror   Link   @5
gggeek commented on pull request kbsali/php-redmine-api#109
Gaetano Giunta

Indeed my PR seems to be a subset of the other one. I did not check thoroughly as it looked so much bigger I assumed it was something unrelated...

01/29/2015 02:41 am   Gaetano @ GitHub   Mirror   Link   @4
Gaetano Giunta

The main question is: can composer deliver both 32/64 bits? And can it detect windows? In other words: can a single package include the 3 binaries,…

01/28/2015 09:36 am   Gaetano @ GitHub   Mirror   Link   @5
gggeek commented on issue kbsali/php-redmine-api#108
Gaetano Giunta

Sent PR: #109

01/27/2015 06:05 am   Gaetano @ GitHub   Mirror   Link   @5