eZecosystem / Mirror / GG @ GitHub

gggeek commented on pull request instaclick/php-webdriver#67
@gggeek

Implemented all changes suggested by @robocoder and squashed. I suggest that the improvements to Travis (testing against multiple versions of Selen…

07/04/2015 12:13 pm   Gaetano @ GitHub   Mirror   Link  
@gggeek
07/04/2015 12:11 pm   Gaetano @ GitHub   Mirror   Link  
@gggeek
07/04/2015 11:57 am   Gaetano @ GitHub   Mirror   Link  
gggeek commented on issue instaclick/php-webdriver#64
@gggeek

@robocoder thanks for the review, will apply changes. I can try to come up with a test matrix for Travis with different selenium versions (but Fire…

07/03/2015 02:57 pm   Gaetano @ GitHub   Mirror   Link   @3
@gggeek
  • @gggeek 299a4b7
    fix package name in composer.json
07/02/2015 12:07 pm   Gaetano @ GitHub   Mirror   Link  
@gggeek
  • @gggeek 85e02ea
    Fix composer.json backslash
07/02/2015 12:06 pm   Gaetano @ GitHub   Mirror   Link   @3
gggeek created repository kaliop-uk/kueueingbundle
07/02/2015 11:08 am   Gaetano @ GitHub   Mirror   Link  
gggeek commented on commit ezsystems/ezflow@7c721d85ca
@gggeek

+1 For the fix, but the unexplained question is: why is this delay needed at all? What does it prevent?

06/30/2015 09:40 am   Gaetano @ GitHub   Mirror   Link   @3
gggeek commented on issue composer/composer#4174
@gggeek

@staabm I agree that Composer does not need to take fully the responsibility for that. That's why I am asking for just a small alteration so far - …

06/23/2015 07:27 am   Gaetano @ GitHub   Mirror   Link   @9
@gggeek
Allow sharing of vendor dir (CI server usecase)
06/23/2015 05:00 am   Gaetano @ GitHub   Mirror   Link   @9
@gggeek
  • @gggeek cc67a43
    Fix ArrayIterator interface implementation; remove usage of arraysize…
  • @gggeek 751f9c9
    Added support for Countable and IteratorAggregate interfaces
  • 13 more commits »
06/17/2015 05:18 pm   Gaetano @ GitHub   Mirror   Link   @17
gggeek commented on pull request instaclick/php-webdriver#67
@gggeek

All points for which there was a clear indication have been tackled. A couple of points remain open for which I have no clear answer on best solution.

06/17/2015 04:34 pm   Gaetano @ GitHub   Mirror   Link   @18
@gggeek
  • @gggeek 202c605
    Fix previous commit: typo
06/17/2015 04:30 pm   Gaetano @ GitHub   Mirror   Link   @10
gggeek commented on pull request instaclick/php-webdriver#67
@gggeek

changed: separate error messages for cases of non-json and non-array or missing-status

06/17/2015 04:29 pm   Gaetano @ GitHub   Mirror   Link   @10
@gggeek
  • @gggeek bcd8fa4
    One more PR fix: even more detailed error message for bad responses f…
06/17/2015 04:28 pm   Gaetano @ GitHub   Mirror   Link   @16
gggeek commented on pull request instaclick/php-webdriver#67
@gggeek

point 2 done

06/17/2015 04:14 pm   Gaetano @ GitHub   Mirror   Link   @8
gggeek commented on pull request instaclick/php-webdriver#67
@gggeek

vhost config removed

06/17/2015 04:14 pm   Gaetano @ GitHub   Mirror   Link   @17
gggeek commented on pull request instaclick/php-webdriver#67
@gggeek

done

06/17/2015 04:13 pm   Gaetano @ GitHub   Mirror   Link   @14
gggeek commented on pull request instaclick/php-webdriver#67
@gggeek

done

06/17/2015 04:13 pm   Gaetano @ GitHub   Mirror   Link   @12
@gggeek
06/17/2015 04:12 pm   Gaetano @ GitHub   Mirror   Link   @11
gggeek commented on pull request instaclick/php-webdriver#65
@gggeek

Well, I work with many OS and VMs, often having the same php app mounted under both linux and windows. Thus I do not have always the same global en…

06/15/2015 06:14 am   Gaetano @ GitHub   Mirror   Link   @14
@gggeek
  • @gggeek 72b0523
    Revert: declare dependency on phpunit
06/15/2015 06:11 am   Gaetano @ GitHub   Mirror   Link   @16
gggeek commented on pull request instaclick/php-webdriver#65
@gggeek

still, having it here does not harm anyone - it allows both usages of composer (installed globally or locally). same for phpstrom files ignore...

06/15/2015 06:09 am   Gaetano @ GitHub   Mirror   Link   @15
gggeek commented on pull request instaclick/php-webdriver#65
@gggeek

I agree about composer.lock. Can remove it if we agree

06/15/2015 06:08 am   Gaetano @ GitHub   Mirror   Link   @16
gggeek commented on pull request instaclick/php-webdriver#67
@gggeek

ps: will squash after all the changes from suggestions

06/15/2015 06:06 am   Gaetano @ GitHub   Mirror   Link   @15
gggeek commented on pull request instaclick/php-webdriver#67
@gggeek

can shorten it. since this weird behaviour is where it all started, I thought a detailed comment was appropriate

06/15/2015 06:05 am   Gaetano @ GitHub   Mirror   Link   @12
gggeek commented on pull request instaclick/php-webdriver#67
@gggeek

well, we do handle, implicitly, by swallowing it

06/15/2015 06:04 am   Gaetano @ GitHub   Mirror   Link   @15
gggeek commented on pull request instaclick/php-webdriver#67
@gggeek

can do < 500 I did not rely on 1st digit only because I was unsure about status codes > 999 being valid, but at least according to rfc7231 they ar…

06/15/2015 06:01 am   Gaetano @ GitHub   Mirror   Link   @16
gggeek commented on pull request instaclick/php-webdriver#67
@gggeek

ok then, will revert

06/15/2015 05:57 am   Gaetano @ GitHub   Mirror   Link   @12