eZ Ecosystem / Mirror / GG @ GitHub

gggeek pushed to master at gggeek/ezpublishbuilder
07/13/2012 10:53 am   GG @ GitHub   View mirror of item   View item
gggeek commented on pull request 370 on ezsystems/ezpublish

Yes

  • custom code might write custom files to var/log without taking into account the new setting => not too important
  • custom code reading/writing to ez log files => will break
07/13/2012 08:37 am   GG @ GitHub   View mirror of item   View item
gggeek commented on pull request 370 on ezsystems/ezpublish

We could default to using var//log and allow user to set it, so that he can separate it between siteaccesses if he wants. But it would be a biggish BC break...

07/13/2012 08:21 am   GG @ GitHub   View mirror of item   View item
gggeek commented on pull request 370 on ezsystems/ezpublish

Nitpicks:

  1. I think commit 3df95e7 is unrelated to this commit

  2. Why use 2 settings? You could use a single one: the name of subir. If it's empty, no subdir is used

  3. Is there any chance for loops/nasty stuff happeining if an error msg has to be logged before siteaccess is fully loaded?

07/13/2012 06:28 am   GG @ GitHub   View mirror of item   View item
gggeek pushed to master at gggeek/ezperformancelogger
  • gggeek committed 8366530
    Add a module and view to diaplsy munin inline in the eZ admin gui
  • gggeek committed 70a959a
    Comments
  • gggeek committed eeadf58
    Major refactoring of the extension;
    - prepare for supporting munin even when apache-log format is used
    - do not rely on 5-minutes intervals anymore for munin stats
    - allow munin to graph page views as well as other PKIs
  • 2 more commits »
06/29/2012 12:17 pm   GG @ GitHub   View mirror of item   View item
gggeek commented on pull request 22 on ezsystems/ezjscore

+1 for adding a parameter rather than extra functions

06/28/2012 04:15 am   GG @ GitHub   View mirror of item   View item
gggeek pushed to master at gggeek/ezperformancelogger
  • gggeek committed 2b4fba0
    Add more "tracing" php classes for clustered installations; alter ini settings and docs
06/27/2012 09:07 am   GG @ GitHub   View mirror of item   View item
gggeek pushed to master at gggeek/ezperformancelogger
06/27/2012 08:22 am   GG @ GitHub   View mirror of item   View item
gggeek commented on pull request 22 on ezsystems/ezjscore

I guess you see the "load" concept a bit differently than I do.

To me:
ezscript_require: declare needed files
ezscript_load: include in html the link to the needed files, which have been magically packed
ezscriptfiles: get as an array the names of the magically packed files

I actually use so seldom ezscript that I had to look up in the code what it does.

Apart from that, ezscriptfiles should imho be a arbon copy of ezscript_load...

06/23/2012 06:12 pm   GG @ GitHub   View mirror of item   View item
gggeek commented on pull request 22 on ezsystems/ezjscore

Functionality looks interesting, but the name of the operator is imho not very clear...

06/23/2012 03:48 pm   GG @ GitHub   View mirror of item   View item

Tags

Mon Tue Wed Thu Fri Sat Sun
    1 2 3 4 5
6 7 8 9 10 11 12
13 14 15 16 17 18 19
20 21 22 23 24 25 26
27 28 29 30 31